On Thu, 6 Nov 2003, Stas Bekman wrote:
Randy Kobes wrote: very neat! A few more comments:
========================================================= Index: Makefile.PL ===================================================================
[...]
+sub fetch_apxs { + my $prefix = $build->{MP_AP_PREFIX} || ''; + my $script = catfile($build->{cwd}, 'build', 'fetch_win32_apxs.pl'); + my @args = ($^X, $script, "--with-apache2=$prefix"); + system(@args) == 0 or die "system @args failed: $?"; }
can you please call it win32_fetch_apxs, or fetch_apxs_win32, or similar and probably add a short comment before it explaining why is it needed.
Sure - that's done below.
Heh, I meant the subroutine, so it won't mislead in Makefile.PL (but the script is a good idea as well)
+sub fetch_apxs {
+ my $prefix = $build->{MP_AP_PREFIX} || '';
+ my $script = catfile($build->{cwd}, 'build', 'win32_fetch_apxs');
+ my @args = ($^X, $script, "--with-apache2=$prefix");
+ system(@args) == 0 or die "system @args failed: $?";
}
Other than that go ahead and commit ;)
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
