On Tue, 18 Nov 2003, Geoffrey Young wrote: > Randy Kobes wrote: > > On Mon, 17 Nov 2003, Geoffrey Young wrote: > > > >>>I dunno, but I am afraid that stuff like device, inode, > >>>nlink and such might not work similarly on non-Unixes.. > >>>These tests most likely need to be a bit more > >>>OS-specific to avoid failures on those OSes > >> > >>yes, I meant to follow this up with an email saying that I > >>would quickly fix any os related issues once randy et al > >>get the chance to play with them and expose where APR is > >>different than perl. but I didn't want to just skip them > >>on win32 before I knew where the issues were, and testing > >>checked in stuff is just easier :) > > > > That's true ... On Win32, inode, device, user, and group are > > all defined, but these tests fail as written, as the > > returned values are different ... The same thing goes for > > the test involving WEXECUTE. Probably one might come up with > > what these returned values would be on Win32, but I'm > > wondering if it's worth it - from what I gather, some of > > these might depend on the Win32 flavour being used (eg, on > > Win9?, any readable file is [almost always] executable). > > Perhaps we could just skip these tests on Win32: > > if the semantics are really that dissimilar, I guess it > makes the most sense to just skip them, especially since > the concept of user and group aren't really meaningful on > win32. I'm glad to see the RW stuff work, though :) > > your patch looks good to me, so commit at will.
OK, I'll do that - thanks ... It is great that the others (RW, size, times) do work. I think the thing with the user/group, indode/device, and execute is that, since there's no universally obvious way to deal with these on Win32, APR does one thing and Perl does another, and the two don't always agree with each other (and also, as I indicated before, the specific disagreement may also depend on the Win32 flavour). However, the fact that the $r->finfo->fname returns undef on Win32 is something that should be tracked down. At the moment I don't see where the trouble lies, as it's statting the right file; it's just that the name isn't getting recorded. -- best regards, randy --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
