On Thu, 2003-12-11 at 11:35, Stas Bekman wrote:
Stas Bekman wrote:
Geoffrey Young wrote:
Stas Bekman wrote:
Currently we allocate a wbucket of type modperl_wbucket_t for each filter invocation. If it's not a streaming filter (i.e. manipulates bucket brigades or doesn't use read/print) it's never going to need wbucket. wbucket consumes 16404 bytes, the filter struct without wbucket consumes 60 bytes. In order not to penalize non-streaming filters, I suggest not to allocate wbucket if and not until it's first used.
I'm getting too comphy with pools and this patch of course forgets to free memory, now that it has moved to malloc.
Here is a proper patch, which now frees the memory for wbucket as well.
Looks like a safe and good idea to me : stas++
Thanks folks, now committed.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
