Rafael Garcia-Suarez wrote:
> Geoffrey Young wrote:
>
>>+ (my $version) = $config->server->{version} =~ m:^Apache/(\d\.\d+\.\d+):;
>>+
>>+ if ($version le 2.0.48) {
>>+ debug("skipping error_log fixup for httpd $version");
>>+ return;
>>+ }
>
>
> This won't work. Remember that 2.0.48 is equivalent to chr(2).chr(0).chr(48).
ah, yes, you're right - it's not so much an issue now unless somebody is
using 2.0.5. but it will be more of an issue when 2.1.10 compares as less
than 2.1.2.
too bad I copied the logic from elsewhere within Apache-Test :)
>
> You could use the terse and hackish
> if (eval($version) le 2.0.48) ...
> or use a CPAN module :)
> or perform a clean separation of $version into major/minor/patchelevel
> and do 3 comparisons.
although it's a moot issue for the proposed patch, it will definitely need
to be fixed elsewhere in the suite. thanks for bringing it up - I'll get on it.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
