Elizabeth Mattijsen wrote:
At 10:54 -0800 1/28/04, Stas Bekman wrote:

Geoffrey Young wrote:

Good. So should we

split /[\r\n]/, $config

if it's a scalar,

we have Apache::CRLF to take the guesswork out, or alternatively we could
use $/.

I don't think it makes any difference, we need to do it in C.


Is this so efficiency bound that it needs to be done in C? Why not change the name of the current add_config sub to something internal and make a Perl wrapper that does the conversion from a scalar to a list ref. From a maintenance point of view, I would think it is preferable to do as much in Perl as possible. It allows people to maintain it without having to become an XS wizard...

It'll just do the equivalent of the same command in perl, but faster.


Yes, mod_perl is all about efficiency. And 99.9% of mp guts is already XS, so if you want to maintain its guts you have little choice but learn the perl API anyway.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to