> Good catch, Geoff! How about this:
>
> Index: src/modules/perl/modperl_mgv.c
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_mgv.c,v
> retrieving revision 1.32
> diff -u -r1.32 modperl_mgv.c
> --- src/modules/perl/modperl_mgv.c 9 Feb 2004 19:32:42 -0000
> 1.32
> +++ src/modules/perl/modperl_mgv.c 10 Feb 2004 17:15:25 -0000
> @@ -277,7 +277,15 @@
> MP_TRACE_h(MP_FUNC, "loaded %s package\n", name);
> }
> else {
> - Perl_croak(aTHX_ "failed to load %s package\n", name);
> + /* the caller doesn't handle the error checking */
> + if (logfailure) {
> + Perl_croak(aTHX_ "failed to load %s package\n", name);
> + }
> + else {
> + /* the caller handles the error checking */
> + MP_TRACE_h(MP_FUNC, "failied to load %s package\n",
> name);
> + return 0;
> + }
> }
> }
> else {
yeah, that looks like it ought to work.
>
> may be we should add a test that catches this case.
I suppose. might be hard to catch, though.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
