>> anyway, I'm not entirely convinced that -D switches are the way to go >> with >> this (imagine the jumble trying to shift just a few phases), but it's >> something to chew on over the weekend :) > > > I'd think that the majority of the users won't need that feature.
I agree > Those > few who would use it, could change the source or use defines. well, the problem with changing the source is that modperl_hooks.c is autogenerated - they'd need to know to alter ModPerl::Code, which is kinda less intuitive unless you're one of us :) what bothers me about -D is that, the more I think about it, we're using -D in a way neither intended by core nor used by other modules. -D is specifically for <IfDefine> containers, while using -D in this way has little do to with that. > > Looks good, Geoff. But even though it's a startup I guess it's > incredibly slow as it has to do strcmp about 120 (20*6) times > multiplied by the number of actual -D passed. So let's say there are 5 > -Ds. It'll be called 600 times. So here is a suggestion: oops, I hadn't thought about that. but I did say it was a rough patch :) I'll see if I can't incorporate some of your suggestions into another pass. thanks for the feedback. --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
