Geoffrey Young wrote:
here's another pass that incorporates the suggestions thus far.  comments on
the global foo appreciated.  the tests I posted before are still valid at
this point.

Much better, but still why having any data at all in mod_perl.c? Have the static variable in modperl_apache.c and provide an accessor to do:


hook_order = apr_table_make(p, 0);

from modperl_apache.c. Now you are all set.

Also, this:

+/* PerlHook*Handler support */
+apr_table_t *hook_order;

needs to be 'static'. Otherwise that symbol ends up in the final library. (again, please refer to Ulrich Drepper's paper: How to Write Shared Libraries http://people.redhat.com/drepper/ukuug2002slides.pdf)


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to