Philippe M. Chiasson wrote:
Sure, using the same method for deciding if we build static in the test does make sense. The only problem is that I was using MP_USE_STATIC in
it right now, so I am not sure I quite understand how MP_USE_STATIC and MP_USE_DSO can be both set at the same time.
lib/ModPerl/BuildOptions.pm:
unless ($build->{MP_USE_DSO} or $build->{MP_USE_STATIC}) { $build->{MP_USE_DSO} = $build->{MP_USE_STATIC} = 1; }
I suppose Doug had the plan to build mod_perl once and then be able to to decide whether to use DSO or static...
Oh, damn I most certainly missed that little one. I imagine that if we can remove that little bit, then USE_STATIC/USE_DSO
is just what is needed for $build->should_link_static then, would it be ?
Remove, no, but something like this will do:
# if no build mode is specified default to DSO unless ($build->{MP_USE_DSO} or $build->{MP_USE_STATIC}) { $build->{MP_USE_DSO} = 1; }
Yes, something like that. Unless you can think of something that would break with this change, make it so ;-)
but otherwise, yes, I prefer to see $build->should_link_static used there.
That means renaming to sub should_link_static { shift->{MP_USE_STATIC} ? 1 : 0 }
and then use it both in the test and in the Makefile.PL.
I'll resubmit a slighlity modified static build patch including that shortly.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
