Here is a new version of the static mod_perl build patch. I think it addresses all the problems raised by the previous one. It doesn't require patching httpd
at all anymore! So, here it is for comments[1]:
Looks too easy :)
Index: Makefile.PL[...]
+ if ($build->should_build_httpd) {
+ ModPerl::MM::add_dep(\$string, pure_all => 'do_httpd');
you've changed the function name but not the make target (do_httpd)
+=head4 MP_DO_HTTPD
and here.
I suggest: build_httpd and MP_BUILD_HTTPD
+Configure and build httpd in C<MP_AP_PREFIX>, linking mod_perl statically +to it.
=head4 MP_STATIC_EXTS
@@ -549,6 +531,12 @@
MP_OPTIONS_FILE=~/.my_mod_perl2_opts
+=head4 MP_AP_CONFIGURE + +The command-line arguments to pass to httpd's configure script. + +C<MP_AP_CONFIGURE> has no effect unless C<MP_DO_HTTPD> is also +specified.
May be it's better if it matches the build name? but I guess it's fine.
More over we have this AP vs httpd thing. May be it'll be more consistent if we use Apache everywhere?
$build->should_build_apache build_apache make target =head4 MP_BUILD_APACHE =head4 MP_AP_CONFIGURE
Another set could be:
$build->should_build_apache ap_build make target =head4 MP_AP_BUILD =head4 MP_AP_CONFIGURE
?
Index: lib/ModPerl/BuildOptions.pm =================================================================== RCS file: /home/cvs/modperl-2.0/lib/ModPerl/BuildOptions.pm,v retrieving revision 1.26 diff -u -I$Id -r1.26 BuildOptions.pm --- lib/ModPerl/BuildOptions.pm 4 Mar 2004 06:01:06 -0000 1.26 +++ lib/ModPerl/BuildOptions.pm 27 May 2004 17:08:40 -0000 @@ -220,6 +220,8 @@ STATIC_EXTS 0 Build Apache::*.xs as static extensions APXS 0 Path to apxs AP_PREFIX 0 Apache installation or source tree prefix +AP_CONFIGURE 0 Apache ./configure arguments +DO_HTTPD 0 Wether to build httpd
s/wether/whether/
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
