Joe Schaefer wrote:
Joe Schaefer <[EMAIL PROTECTED]> writes:

[...]


Correction: t/filter/in_init_basic.t is now failing with both
worker and prefork.  Investigating...


The patch is fine; test itself is borked (too many qr's). Here's the patch, the args also need to be reordered because
Test.pm v1.24 deprecates using regexps in the first argument.


Index: t/filter/in_init_basic.t
===================================================================
RCS file: /home/cvspublic/modperl-2.0/t/filter/in_init_basic.t,v
retrieving revision 1.4
diff -u -r1.4 in_init_basic.t
--- t/filter/in_init_basic.t    6 Aug 2003 07:06:23 -0000       1.4
+++ t/filter/in_init_basic.t    13 Jun 2004 16:12:14 -0000
@@ -13,4 +13,4 @@

 my $location = '/TestFilter__in_init_basic';
 my $response = POST_BODY $location, content => $content;
-ok t_cmp(qr/$expected/, qr/$response/, "test filter init functionality");
+ok t_cmp($response, qr/$expected/, "test filter init functionality");

Thanks Joe, committed.


-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to