Joe Schaefer wrote:
Stas Bekman <[EMAIL PROTECTED]> writes:

[...]


The rest is hard to tell as it's a big patch. Hopefully
nothing was missed. So go ahead and apply it and we will
take it from there. As I originally mentioned there were a
few minor issues with my original patch, but they may
remove themselves as you adjust it to work with win32.


A data point:

The cgi.t test in httpd-apreq-2/glue/perl/t/apreq can be made to pass
all its tests now.  However there were two things I needed to do to
make that happen:

  1)  Add a LIBS=> "$aprutil_libs $apr_libs" argument to the
      ModPerl::BuildMM::WriteMakefile call in lib/ModPerl/WrapXS.pm,
      similar to the line in httpd-apreq2/build/xsbuilder.pl.

Perhaps we need to add a special wrapper to add these flags.

Why are you using BuildMM and not MM for libapreq? BuildMM is for mod_perl only or do you mean something else?

  2) Expose APR::General::initialize in xs/maps/apr_functions.map
     and call it at the top of the (generated) test_cgi.pl script.

That shouldn't be the case if you 'use APR', which does that thing already. I was thinking to have all APR:: modules load APR.pm internally.



-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to