Randy Kobes <[EMAIL PROTECTED]> writes:

[...]

> ==================================================================
> #include "mod_perl.h"
> #include "modperl_common_util.h"
> 
> /* XXX: provide the missing symbol for APR::Pool as a tmp workaround  */
> #ifndef modperl_interp_unselect
> apr_status_t modperl_interp_unselect(modperl_interp_t *interp) {


This has a different signature from the one in modperl_common_util.h,
so you probably want

    apr_status_t modperl_interp_unselect(void *data) {
        modperl_interp_t *interp = data;

[...]

> (I know I shouldn't be including mod_perl.h, but I did that
> just to quickly define modperl_interp_t). In any case, this
> seems to fix the problems, and all the tests pass for me,
> including the apr-ext ones.

I don't notice any change on debian-amd64 - all tests pass either 
way (except t/protocol/echo_timeout.t, which is expected since 
I'm testing against HEAD for apr & httpd-2.0).  However, given
that mpxs_apr_pool_cleanup_register increments refcnt, your 
implementation seems to be an improvement over current-cvs.

-- 
Joe Schaefer


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to