[EMAIL PROTECTED] wrote:
[...]
1.1 modperl-2.0/xs/APR/aprext/Makefile.PL
Index: Makefile.PL
===================================================================
use strict;
use warnings;
use lib qw(../lib);
use ModPerl::BuildMM ();
use Apache::Build ();
my $srcdir = '../../../src/modules/perl';
my @names = map { "modperl_$_" } (qw(error bucket),
map { "common_$_" } qw(util log));

./xs/APR/aprext/Makefile.PL: map { "common_$_" } qw(util log)); ./xs/APR/APR/Makefile.PL: map { "common_$_" } qw(util log));

Now we have two places where there is the same code, and chances are that we will not remember to update one, when fixing the other (since aprext is needed for win32 only). Therefore we need to abstract that into a function, so there is only one source to change (somewhere under modperl-2.0/lib/, most likely lib/ModPerl/Code.pm is the best fit).

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to