Randy Kobes wrote: [...]
That's a good point - what about the following, which should also include Marcus' case of using MP_APXS instead
+1, but the style is not right.
+ if (Apache::TestConfig::WIN32) {
+ my $ap_bindir = $build->apr_bindir();
+ if (! $ap_bindir) {
+ $ap_bindir = $build->{MP_AP_PREFIX} ?
+ File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin') : '';
+ }
and may be it's easier to read it as:
my $ap_bindir = $build->apr_bindir() || '';
unless ($ap_bindir) {
$ap_bindir = File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin')
if $build->{MP_AP_PREFIX};
}If apr was put into a different directory than apache.exe, then I think this is still OK (assuming apr_bindir() is successful), as it's really the apr dlls that are needed.
OK
BTW, env is not needed for win32?
No ... Even moreso, if I remember correctly, leaving it in on Win32 confused some commands in the build, which is why it was taken out for Win32.
Got it, thanks. if there was a comment there, I won't have asked... hint, hint :)
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
