Fred Moyer wrote:
Per Stas Bekman's request I have reviewed the accessor settings in modperl-2.0/xs/maps/apache_structures.map against the doc pages for entries that should be read/write and generated a diff [1] against the current cvs.
Excellent, thanks a lot!
I have found methods in the man pages which are not in structures.map, and some methods which look like they should be read only, but no methods so far which should be changed to read/write. Most of this diff is for methods that are currently read/write and look like they should be read only.
Make test has returned 'All tests successful' with this modified file apache_structures.map. Should this patch be acceptable please let me know if I should add additional methods that are doumented but not in the map file.
Thanks,
Fred
[1]
--- apache_structures.map 8 Aug 2004 18:04:55 -0000 1.36 +++ apache_structures.map 10 Aug 2004 13:57:25 -0000 @@ -28,7 +28,7 @@ allowed_xmethods allowed_methods > sent_bodyct - bytes_sent +< bytes_sent
Couldn't some module want to change this field ? gzipping filter, for example ?
mtime > chunked > range @@ -51,7 +51,7 @@ user ap_auth_type ~ no_cache - no_local_copy +< no_local_copy < unparsed_uri uri filename @@ -100,26 +100,26 @@ </server_rec>
<conn_rec> - pool - base_server +< pool +< base_server
Definitely !
> vhost_lookup_data - local_addr - remote_addr - remote_ip - remote_host +< local_addr +< remote_addr +< remote_ip +< remote_host
I think a module might have a valid reason to want to change what other modules will think the local/remote IP information is.
remote_logname - aborted +< aborted
Again, wouldn't setting $r->connection->aborted(1) be potentially usefull ?
keepalive
? double_reverse
keepalives
- local_ip
- local_host
- id
+< local_ip
+< local_host
See remote_addr, remote_ip ,etc
+< id conn_config notes input_filters output_filters - sbh +< sbh bucket_alloc </conn_rec>
@@ -131,11 +131,17 @@ </server_addr_rec>
<module> - version - minor_version - module_index - name - dynamic_load_handle +< version +< find_linked_module +< find_module_name + remove_loaded_module + remove_module +< top_module +< version +< minor_version +< module_index +< name +> dynamic_load_handle next > magic - rewrite_args @@ -143,7 +149,7 @@ > merge_dir_config > create_server_config > merge_server_config - cmds +< cmds > register_hooks </module>
@@ -156,6 +162,9 @@ </process_rec>
<command_rec> +< chk_cmd_context +< soak_end_container +< next name func cmd_data @@ -185,14 +194,18 @@ </ap_method_list_t>
<ap_directive_t> - directive +< as_hash +< as_string +< lookup + walk_config
Those 4 are not even members of that structure ?!
+< directive
args
- next
- first_child
- parent
+< next
+< first_child
+< parent
I am not yet quite sure why, but I wouldn't want to remove the possiblilty of re-arranging the configuration tree at this point.
data - filename - line_num +< filename +< line_num </ap_directive_t>
I think I'd leave all the ap_directive_t fields alone at this point, unless anybody can find a strong reason _why_ it should read-only ?
!<ap_configfile_t>
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
