[Patch mp2] Suggest renaming Apache::Module $module->version

[Philippe M. Chiasson]

Stas Bekman wrote:
Geoffrey Young wrote:
what about just api_version()?  I think that sets it apart enough from
perlish ideas about require() and provides a means to explain the
exactness
of the required match.

+1 for the exactness, but it's still ambiguous of what api_ it's talking
about. apr API, mod_perl API, perl API, apache API?

ok, apache_api_version() then?  I'd hate to see it any longer than that.

+1
Patch attached.
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Index: Changes
===================================================================
RCS file: /home/cvs/modperl-2.0/Changes,v
retrieving revision 1.485
diff -u -I$Id -r1.485 Changes
--- Changes	16 Sep 2004 16:36:28 -0000	1.485
+++ Changes	16 Sep 2004 20:10:49 -0000
@@ -12,6 +12,9 @@
 
 =item 1.99_17-dev
 
+Apache::Module $mod->version() renamed $mod->apache_api_version()
+for clarity [Gozer]
+
 Apache::Log changes: [Stas]
   - moved to compat: Apache::warn, Apache->warn, Apache::Server->warn,
     Apache::Server::warn
Index: t/response/TestAPI/module.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestAPI/module.pm,v
retrieving revision 1.22
diff -u -I$Id -r1.22 module.pm
--- t/response/TestAPI/module.pm	13 Sep 2004 22:36:18 -0000	1.22
+++ t/response/TestAPI/module.pm	16 Sep 2004 20:10:49 -0000
@@ -84,7 +84,7 @@
         my $name = $modp->name;
         ok $name;
         t_debug("Testing module: " . $modp->name);
-        ok $modp->version == $mmn_major;
+        ok $modp->apache_api_version == $mmn_major;
         ok $modp->minor_version <= $mmn_minor;
         ok $modp->module_index >= 0;
         my $cmds = $modp->cmds;
Index: xs/Apache/Module/Apache__Module.h
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/Apache/Module/Apache__Module.h,v
retrieving revision 1.13
diff -u -I$Id -r1.13 Apache__Module.h
--- xs/Apache/Module/Apache__Module.h	13 Sep 2004 22:36:19 -0000	1.13
+++ xs/Apache/Module/Apache__Module.h	16 Sep 2004 20:10:49 -0000
@@ -61,3 +61,9 @@
 
     return SvREFCNT_inc(obj);
 }
+
+static MP_INLINE
+int mpxs_Apache__Module_apache_api_version(pTHX_ module *mod)
+{
+    return mod->version;
+}
Index: xs/maps/apache_functions.map
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/maps/apache_functions.map,v
retrieving revision 1.102
diff -u -I$Id -r1.102 apache_functions.map
--- xs/maps/apache_functions.map	14 Sep 2004 17:48:15 -0000	1.102
+++ xs/maps/apache_functions.map	16 Sep 2004 20:10:49 -0000
@@ -214,6 +214,7 @@
  mpxs_Apache__Module_loaded
  #ap_get_module_config
  mpxs_Apache__Module_get_config | | pmodule, s, v=NULL
+ mpxs_Apache__Module_apache_api_version
 
 MODULE=Apache::Directive
  ap_directive_t *:DEFINE_conftree
Index: xs/maps/apache_structures.map
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/maps/apache_structures.map,v
retrieving revision 1.46
diff -u -I$Id -r1.46 apache_structures.map
--- xs/maps/apache_structures.map	22 Aug 2004 20:47:37 -0000	1.46
+++ xs/maps/apache_structures.map	16 Sep 2004 20:10:49 -0000
@@ -131,7 +131,7 @@
 </server_addr_rec>
 
 <module>
-<  version
+~  version
 <  minor_version
 <  module_index
 <  name
Index: xs/tables/current/ModPerl/FunctionTable.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/tables/current/ModPerl/FunctionTable.pm,v
retrieving revision 1.181
diff -u -I$Id -r1.181 FunctionTable.pm
--- xs/tables/current/ModPerl/FunctionTable.pm	14 Sep 2004 13:37:21 -0000	1.181
+++ xs/tables/current/ModPerl/FunctionTable.pm	16 Sep 2004 20:10:49 -0000
@@ -2,7 +2,7 @@
 
 # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 # ! WARNING: generated by ModPerl::ParseSource/0.010
-# !          Mon Sep 13 14:52:36 2004
+# !          Thu Sep 16 12:12:26 2004
 # !          do NOT edit, any changes will be lost !
 # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
@@ -6163,6 +6163,20 @@
       {
         'type' => 'int',
         'name' => 'query_code'
+      }
+    ]
+  },
+  {
+    'return_type' => 'int',
+    'name' => 'mpxs_Apache__Module_apache_api_version',
+    'args' => [
+      {
+        'type' => 'PerlInterpreter *',
+        'name' => 'my_perl'
+      },
+      {
+        'type' => 'module *',
+        'name' => 'mod'
       }
     ]
   },
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]