Markus Wichitill wrote:
Stas Bekman wrote:

BTW, the only working path delimiter syntax in the SKIP file on Win32 seems to be "perl\\ithreads.t" (i.e. two backslashes), this should probably be noted on that page.


Patches are welcome :)

Either to the doc as you've suggested:
http://perl.apache.org/contribute/index.html

Or to Apache-Test code to handle unix path style on win32


I figured that of the dozen possible ways to document or fix this, my tiny patch would probably not be the preferred one, but here you go:

Index: Apache-Test/lib/Apache/TestHarness.pm
===================================================================
RCS file: /home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestHarness.pm,v


retrieving revision 1.19
diff -u -r1.19 TestHarness.pm
--- Apache-Test/lib/Apache/TestHarness.pm 9 Aug 2004 13:26:10 -0000 1.19
+++ Apache-Test/lib/Apache/TestHarness.pm 17 Sep 2004 15:11:46 -0000
@@ -167,6 +167,9 @@
@tests = $self->prune(@tests);


     if (my $skip = $self->skip) {
+        # Allow / \ and \\ path delimiters in SKIP file
+        $skip =~ s![/\\\\]+![/\\\\]!g;
+
         @tests = grep { not /(?:$skip)/ } @tests;
     }

Excellent, committed.

I'd prefer the latter, so we can commit that t/perl/all.t to skip that test for everybody, until it gets resolved.


Hm, what's all.t got to do with this? There's still perl/api.t and perl/hash_attack.t.

right, it should be t/SKIP.

Thanks, Markus!

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to