thanks and done.

Stas Bekman wrote:
Philippe M. Chiasson wrote:

One more item off todo/release for today. This patch changes

my $tid_obj = APR::OS::thread_current();
my $tid = $$tid_obj;

to

my $tid = APR::OS::current_thread_id();


+1 with 2 fixes below:

and don't forget to fix the manpage. Thanks.


Index: Changes
===================================================================
RCS file: /home/cvs/modperl-2.0/Changes,v
retrieving revision 1.495
diff -u -I$Id -r1.495 Changes
--- Changes     22 Sep 2004 01:29:31 -0000      1.495
+++ Changes     22 Sep 2004 21:45:54 -0000
@@ -12,6 +12,10 @@

=item 1.99_17-dev

+APR::OS::thread_current renamed APR::OS::current_thread_id and
+it now returns the actual thread_id instead of an object that
+needed to be dereferenced to get at the thread_id [Gozer]
+
change a bunch of the APR:: constants to have a better prefix
(APR::FILETYPE_* and APR::FILEPROT_). libapr will be changed soon too
[Stas]
Index: t/response/TestAPR/os.pm


    if (Apache::MPM->is_threaded) {
-        my $id = APR::OS::thread_current();
-        ok t_cmp("$id", "$id", "current thread");
-        ok t_cmp($$id, $$id, "current thread");
+        my $id = APR::OS::current_thread_id();
+        ok t_cmp($id, $id, "current thread($id/$$)");


better:

my $tid = APR::OS::current_thread_id();
ok t_cmp($tid, $tid, "current thread id: $tid / pid: $$");


Index: xs/maps/apr_functions.map


MODULE=APR::OS
+ mpxs_APR__OS_current_thread_id
-apr_os_dir_get
-apr_os_exp_time_get
-apr_os_file_get
@@ -630,7 +631,6 @@
-apr_os_threadkey_put
-apr_os_dso_handle_get
-apr_os_dso_handle_put
- apr_os_thread_current | mpxs_


don't remove C functions, but mark them with ~ if you impelement them via a wrapper.


-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to