Stas Bekman wrote:
Pratik wrote:
I was building mp2 statically ( latest cvs version ) with the following :
perl Makefile.PL MP_USE_STATIC=1 MP_INST_APACHE2=1 MP_AP_PREFIX=/home/pratik/src/mp2/httpd-2.0.51 MP_MAINTAINER=1 MP_AP_CONFIGURE="--enable-maintainer-mode --enable-so --enable-rewrite --enable-logio --enable-log-forensic"
But "make install" failed with the following message.
cd "src/modules/perl" && make install
make[1]: Entering directory `/home/pratik/src/mp2/modperl-2.0/src/modules/perl'
test -f mod_perl.so && \
cp mod_perl.so /home/pratik/src/mp2/httpd-2.0.51/modules
make[1]: *** [install] Error 1
make[1]: Leaving directory `/home/pratik/src/mp2/modperl-2.0/src/modules/perl'
make: *** [modperl_lib_install] Error 2
I just created a dummy mod_perl.so in src/modules/perl and did 'make install'. After that it worked properly.
Thanks for the report, Pratik. Philippe is taking care of fixing it.
And it has been fixed just now. Thanks for the feedback Pratik! Can you try with
the latest mod_perl-2.0 CVS and confirm it fixes the problem for you? Thanks!
? mod_perl-1.99_17-dev.tar.gz
Index: Changes
===================================================================
RCS file: /home/cvs/modperl-2.0/Changes,v
retrieving revision 1.500
diff -u -I$Id -r1.500 Changes
--- Changes 26 Sep 2004 03:12:38 -0000 1.500
+++ Changes 26 Sep 2004 07:04:41 -0000
@@ -12,6 +12,9 @@
=item 1.99_17-dev
+make install and static build now correctly installs mod_perl as
+well as the statically build apache [Gozer]
+
if some code changes the current interpreter's tainted state to on,
the return value from the handler callback will be tainted, and we
fail to deal with that. So revert to coercing any return value, but
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.162
diff -u -I$Id -r1.162 Makefile.PL
--- Makefile.PL 25 Sep 2004 01:53:34 -0000 1.162
+++ Makefile.PL 26 Sep 2004 07:04:42 -0000
@@ -559,7 +559,13 @@
if ($build->should_build_apache) {
ModPerl::MM::add_dep(\$string, pure_all => 'ap_build');
- $string .= qq[\nap_build: modperl_lib\n\tcd "$build->{MP_AP_PREFIX}" && make\n];
+ $string .= <<"EOF";
+ap_build: modperl_lib
+ cd "$build->{MP_AP_PREFIX}" && make
+
+ap_install: ap_build
+ cd "$build->{MP_AP_PREFIX}" && make install
+EOF
}
ModPerl::MM::add_dep(\$string, pure_all => 'modperl_lib');
@@ -627,6 +633,8 @@
sub MY::install {
my $self = shift;
my $string = $self->MM::install(@_);
+ ModPerl::MM::add_dep(\$string, pure_install => 'ap_install')
+ if $build->should_build_apache;
ModPerl::MM::add_dep(\$string, pure_install => 'modperl_lib_install');
ModPerl::MM::add_dep(\$string, pure_install => 'modperl_xs_h_install');
# ModPerl::MM::add_dep(\$string, pure_install => 'aprext_install')
Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.185
diff -u -I$Id -r1.185 Build.pm
--- lib/Apache/Build.pm 22 Sep 2004 23:10:48 -0000 1.185
+++ lib/Apache/Build.pm 26 Sep 2004 07:04:42 -0000
@@ -1495,10 +1495,17 @@
my $install = <<'EOI';
install:
+EOI
+ if (!$self->should_build_apache) {
+ $install .= <<'EOI';
# install mod_perl.so
@$(MKPATH) $(MODPERL_AP_LIBEXECDIR)
$(MODPERL_TEST_F) $(MODPERL_LIB_DSO) && \
$(MODPERL_CP) $(MODPERL_LIB_DSO) $(MODPERL_AP_LIBEXECDIR)
+EOI
+ }
+
+ $install .= <<'EOI';
# install mod_perl .h files
@$(MKPATH) $(MODPERL_AP_INCLUDEDIR)
$(MODPERL_CP) $(MODPERL_H_FILES) $(MODPERL_AP_INCLUDEDIR)
signature.asc
Description: OpenPGP digital signature
