On Tue, Sep 28, 2004 at 06:55:32PM -0400, Stas Bekman wrote:
> Joe Orton wrote:
> >Index: modperl_filter.c
> >===================================================================
> >RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/modperl_filter.c,v
> >retrieving revision 1.98
> >diff -u -r1.98 modperl_filter.c
> >--- modperl_filter.c 9 Sep 2004 15:17:20 -0000       1.98
> >+++ modperl_filter.c 28 Sep 2004 21:35:28 -0000
> >@@ -318,6 +318,8 @@
> >     }
> >     filter = (modperl_filter_t *)apr_pcalloc(temp_pool, sizeof(*filter));
> >                 
> >+    apr_pool_tag(temp_pool, "mod_perl temp filter");
> >+
> 
> but this one happens at run time, what's the overhead of the pool tagging 
> operation? should we do that only for the maintainer version?

The overhead is a function call and a single pointer assignment, i.e. 
compared to the apr_pcalloc above, pretty much lost in the noise, so
it's OK to do it for the non-maintainer build too.

joe


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to