Joe Schaefer wrote:
Joe Orton <[EMAIL PROTECTED]> writes:
I'm not sure if you guys noticed but since I changed ap_save_brigade's
handling of ENOTIMPL setasides on HEAD (motivated by a similar issue)
there are now several tests always failing:
t/filter/out_bbs_basic.t 255 65280 ?? ?? % ??
t/filter/out_bbs_ctx.t 1 1 100.00% 1
t/filter/out_bbs_filebucket.t 10 2 20.00% 1-2
these fail because ap_save_brigade now fails immediately if ->setaside()
is ENOTIMPL and ->read() does not morph the bucket. core_output_filter
rudely ignores the ap_save_brigade return value and so silently the
entire response gets dropped on the floor.
Yes, I'm aware, and my recent (large) bucket brigade patch takes
care of this, because it implements a proper setaside function.
These tests should pass if you apply the patch.
Perfect timing, joe&&joe++ :)
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
