Christopher H. Laco wrote:
Christopher H. Laco wrote:
[snip]

Changing my httpd.conf fixes the failing test. Now, I assumed if was just a matter of changing

plan tests => 1, need need_module('proxy'),
    need_access;


to

plan tests => 1, need need_module(['proxy', 'proxy_http']),
    need_access;


However, no encantation of proxy_http, mod_proxy_http.c seems to work. The all fail to recognize that mod_proxy_http.so is loaded. A::T::need_module looks fine, but maybe I'm missing something.


Any ideas?


And here's the problem.....a dump of $cfg->{modules} during need_module shows this:

    ...
    mod_deflate.c
    mod_proxy.c
    core.c
    http_core.c
    proxy_http.c    <----- Hey, that's not intuitive given the
                LoadModule line. :-)
    mpm_winnt.c
    ...


Of course, it will never find it as it's assuming mod_$module.c.

What's the best way to deal with this? Simply pass in proxy_http.c since need_module leaves *.c modules as-is?

Seems kind of dirty, but it works.

-=Chris

Here's a patch to make sure we check for both the proxy and the proxy_http modules.



-=Chris
Index: t/filter/both_str_req_proxy.t
===================================================================
--- t/filter/both_str_req_proxy.t       (revision 111185)
+++ t/filter/both_str_req_proxy.t       (working copy)
@@ -5,7 +5,8 @@
 use Apache::TestRequest;
 use Apache::TestUtil;
 
-plan tests => 1, need need_module('proxy'), need_access;
+plan tests => 1, need need_module(qw(proxy proxy_http.c)),
+    need_access;
 
 my $data = join ' ', 'A'..'Z', 0..9;
 my $expected = lc $data; # that's what the input filter does
Index: t/modules/proxy.t
===================================================================
--- t/modules/proxy.t   (revision 111185)
+++ t/modules/proxy.t   (working copy)
@@ -10,8 +10,8 @@
 
 t_debug("connecting to $url");
 
-plan tests => 1, (need_module('proxy') &&
-                  need_access);
+plan tests => 1, need need_module(qw(proxy proxy_http.c)),
+    need_access;
 
 my $expected = "ok";
 my $received = GET_BODY_ASSERT $url;

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to