On Win32, the last subtest of t/directive/setupenv.t tests that $env{HOME} doesn't exist. However, as we've discussed before in some other contexts, for some reason Win32 does pass, in particular, the HOME environment variable, if it's set. I have HOME set, and consequently, this last subtest fails.
I'm not sure if this different behaviour is due to mp2 or to Apache. In the meantime, would it be acceptable to skip this subtest for Win32:
+1, but please add a little comment, like:
# on win32 sometimes $ENV{HOME} is set (probably by Apache) and
# sometimes it's notBut may be we should choose a different ENV var which exists on all OSes? SHELL? USER?
======================================================= Index: t/directive/setupenv.t =================================================================== --- t/directive/setupenv.t (revision 111576) +++ t/directive/setupenv.t (working copy) @@ -5,6 +5,8 @@ use Apache::TestRequest; use Apache::TestUtil;
+use constant WIN32 => Apache::TestConfig::WIN32; + plan tests => 3;
my $location = '/TestDirective__setupenv'; @@ -23,4 +25,10 @@
ok t_cmp $env{REQUEST_URI}, $location, "testing REQUEST_URI";
-ok not exists $env{HOME}; +if (WIN32) { + skip "different environment variable expectations on Win32", 0; +} +else { + ok not exists $env{HOME}; +} +
=====================================================================
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
