Randy Kobes wrote:
In APR__Pool.h and Apache__ServerUtil.h, should
the PerlInterpreter structure member be surrounded
by an #ifdef USE_ITHREADS:
========================================================
Index: xs/APR/Pool/APR__Pool.h
===================================================================
--- xs/APR/Pool/APR__Pool.h (revision 111605)
+++ xs/APR/Pool/APR__Pool.h (working copy)
@@ -233,8 +233,8 @@
SV *cv;
SV *arg;
apr_pool_t *p;
+#ifdef USE_ITHREADS
PerlInterpreter *perl;
-#ifdef USE_ITHREADS
modperl_interp_t *interp;
#endif
} mpxs_cleanup_t;
yes, but that will break:
static apr_status_t mpxs_cleanup_run(void *data)
{
int count;
mpxs_cleanup_t *cdata = (mpxs_cleanup_t *)data;
dTHXa(cdata->perl);
in non-threaded perl.
Index: xs/Apache/ServerUtil/Apache__ServerUtil.h
===================================================================
--- xs/Apache/ServerUtil/Apache__ServerUtil.h (revision 111605)
+++ xs/Apache/ServerUtil/Apache__ServerUtil.h (working copy)
@@ -33,7 +33,9 @@
SV *cv;
SV *arg;
apr_pool_t *p;
+#ifdef USE_ITHREADS
PerlInterpreter *perl;
+#endif
} mpxs_cleanup2_t;
same here
I'll commit the extra ifdefs after some more testing.
Thanks Randy.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
