Markus Wichitill wrote:
Randy Kobes wrote:

a recent change (rename branch) in ModPerl::BuildMM trips the CPAN shell's
reinstall-recommendations command:


Does the following help?
- my $pm_to_blib = ($ExtUtils::MakeMaker::VERSION >= 6.22 &&
- $ExtUtils::MakeMaker::VERSION <= 6.25 )
+ my $pm_to_blib = ($ExtUtils::MakeMaker::VERSION >= 6.22 && $ExtUtils::MakeMaker::VERSION <= 6.25 )


Yes, thanks.

But this wasn't committed.

How about this patch, that better fits our style guidelines:

Index: lib/ModPerl/BuildMM.pm
===================================================================
--- lib/ModPerl/BuildMM.pm      (revision 160192)
+++ lib/ModPerl/BuildMM.pm      (working copy)
@@ -189,8 +189,8 @@
     # create a dependency on pm_to_blib subdirs linkext targets to
     # allow 'make -j'
     require ExtUtils::MakeMaker;
-    my $pm_to_blib = ($ExtUtils::MakeMaker::VERSION >= 6.22 &&
-                      $ExtUtils::MakeMaker::VERSION <= 6.25 )
+    my $mm_ver = $ExtUtils::MakeMaker::VERSION;
+    my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25 )
         ? "pm_to_blib.ts"
         : "pm_to_blib";
     my @target = ("glue_pods: $pm_to_blib subdirs linkext");


-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to