All,
Can I have some +/- 1s please ? :)
Patch attached.
I'll confirm this "works" on at least the following:
FreeBSD 5.4-RELEASE
FreeBSD 6.0-BETA2
FreeBSD 7.0-CURRENT
and
Linux 2.4.21-15.EL #1 i686 i686 i386 GNU/Linux
with perl 5.8.7 and latest SVN of mp2.
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Index: todo/bugs_build
===================================================================
--- todo/bugs_build (revision 230957)
+++ todo/bugs_build (working copy)
@@ -65,15 +65,6 @@
xs/modperl_xs*.h, when the latter change 'make' won't rebuild the
dependant files
-* gcc 3.3 (from cvs 2003-07-28) supports a new option:
- -Wdeclaration-after-statement, which we need to enable in the
- maintainer mode, to catch any declarations after statements, since
- by default gcc doesn't complain about them. Probably need to wait
- till gcc-3.3.2 and enable it then.
-
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?r1=2.639&r2=2.640&f=h
-[pgollucci volunteers]
-
-
* Testing:
Need to put Philippe's smoking test into the core
-- shouldn't forget to test with perlio enabled and disabled
Index: lib/Apache2/Build.pm
===================================================================
--- lib/Apache2/Build.pm (revision 230957)
+++ lib/Apache2/Build.pm (working copy)
@@ -518,10 +518,22 @@
if ($self->{MP_MAINTAINER}) {
$self->{MP_DEBUG} = 1;
- if ($self->perl_config('gccversion')) {
+
+ my $gccversion;
+ if (my $gccversion = $self->perl_config('gccversion')) {
#same as --with-maintainter-mode
$ccopts .= " $Wall -DAP_DEBUG";
$ccopts .= " -DAP_HAVE_DESIGNATED_INITIALIZER";
+
+ $gccversion =~ /^(.*?)\s/;
+ $gccversion = $1;
+ $gccversion =~ s/\D//g;
+
+ $gccversion = $gccversion . "0" if length $gccversion < 3;
+
+ if ($gccversion >= 332) {
+ $ccopts .= " -Wdeclaration-after-statement";
+ }
}
}
Index: Changes
===================================================================
--- Changes (revision 230957)
+++ Changes (working copy)
@@ -12,6 +12,10 @@
=item 2.0.2-dev
+When compiling with MP_MAINTAINER=1 andd gcc 3.3.2 or higher,
+add the -Wdeclaration-after-statement compilation flag.
+[Philip M. Gollucci]
+
another round of cygwin fixes [Nick *** <[EMAIL PROTECTED]>]
Multiple fixes to make mod_perl 2.0 work with blead-perl (5.9.3+)
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
