Geoffrey Young wrote: > > Philip M. Gollucci wrote: > >>Geoff, >> >>http://aspn.activestate.com/ASPN/Mail/Message/modperl/2871864 >> >>I never saw this get committed .......... ? >> >>What needs to happen for that ? > > > I think I was waiting for him to get back to me with some real test results, > which IIRC he said he would do when he could upgrade :) > > remarks on the list as to the thread safety made me a bit nervous about > commiting this particular bit, just because I don't have a clue when it > comes to threads. but if someone with a clue takes a look and think it > looks ok I'll be happy to commit.
looks like something is missing from that patch: ConnectionUtil.xs: In function 'XS_Apache2__Connection_pnotes': ConnectionUtil.xs:36: warning: implicit declaration of function 'mpxs_Apache2__Connection_pnotes' ConnectionUtil.xs:36: warning: assignment makes pointer from integer without a cast make[3]: *** [ConnectionUtil.o] Error 1 -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
