Geoffrey Young <[EMAIL PROTECTED]> wrote:
> for this, it's
>
> http://svn.apache.org/repos/asf/perl/Apache-Test/
>
> --Geoff
OK... Just doing a quick grep for EXTRA_ARGS in trunk/,
it appears that only TestMM and TestMB.pm actually *have* it. The reason it
works on the MM size is because it's makefile snippets actually use it. The
following patch fixes *that*, but there's still some other concerning
behaviour:
[warning] server crackerjack:8529 shutdown
[warning] port 8529 still in use...
...............[ error]
server was shutdown but port 8529 is still in use, please shutdown the
service using this port or select another port for the tests
[ error] port 8529 is in use, cannot determine server pid to shutdown
[ error] error running tests (please examine t/logs/error_log)
After the test shuts down completely, the apache process is still
there, and has to be killed before I can run the test again:
$ ./Build testcover
/usr/bin/perl -I /home/faraway/dev/Apache2-AUS/blib/lib -I
/home/faraway/dev/Apache2-AUS/blib/arch t/TEST -clean -one-process
[warning] setting ulimit to allow core files
ulimit -c unlimited; /usr/bin/perl /home/faraway/dev/Apache2-AUS/t/TEST
-clean -one-process
[ error] kill 3642 failed: No such process
[ error] port 8529 is in use, cannot determine server pid to shutdown
This is better than it not working at all, but still pretty bad :-/
- Tyler
Index: lib/Apache/TestMB.pm
===================================================================
--- lib/Apache/TestMB.pm (revision 384402)
+++ lib/Apache/TestMB.pm (working copy)
@@ -37,12 +37,17 @@
return $self->{properties}{apache_test_script};
}
+sub apache_test_extra_args {
+ return $ENV{APACHE_TEST_EXTRA_ARGS} ? ($ENV{APACHE_TEST_EXTRA_ARGS}) : ();
+}
+
sub ACTION_test_clean {
my $self = shift;
# XXX I'd love to do this without t/TEST.
$self->do_system( $self->perl, $self->_bliblib,
$self->localize_file_path($self->apache_test_script),
- '-clean');
+ '-clean', $self->apache_test_extra_args
+ );
}
sub ACTION_clean {
@@ -57,7 +62,9 @@
# XXX I'd love to do this without t/TEST.
$self->do_system($self->perl, $self->_bliblib,
$self->localize_file_path($self->apache_test_script),
- '-bugreport', '-verbose=' . ($self->verbose || 0));
+ '-bugreport', '-verbose=' . ($self->verbose || 0),
+ $self->apache_test_extra_args
+ );
}
sub ACTION_testcover {
@@ -87,7 +94,9 @@
my $self = shift;
$self->do_system($self->perl, $self->_bliblib,
$self->localize_file_path($self->apache_test_script),
- '-conf', '-verbose=' . ($self->verbose || 0));
+ '-conf', '-verbose=' . ($self->verbose || 0),
+ $self->apache_test_extra_args
+ );
}
sub _bliblib {
@@ -391,4 +400,3 @@
I<http://perl.apache.org/docs/general/testing/testing.html>.
=cut
-
