Hi Geoff, As already said I'd also like to see this fix in the next release but I'd like to have a rc released to users which is announced at the user-mailing list pointing to this "API"-Change and in the same time I'd propose the following documentation patch.
Tom Geoffrey Young wrote: >>>So does anybody think this behaviour shouldn't be 'fixed' in 2.0 ? >>> >> >> >>Yes, I do not because I use this feature or think it should be changed >>but it simply changes how mp2 behaves within a stable release-cycle but >>that's only my opinion. > > > I agree with you in principle. however, historically mod_perl has been a > bit more flexible with its public interface based on the general community > feeling that a "fixed in stone" API is less useful than one that actually > works or is dwimmy from a developer standpoint. and in truth, this isn't an > API change - you still call pnotes() the same way you always did, and it > still behaves the same way under most normal circumstances. > > so I think we can get away with changing this behavior in 2.0. not that I'm > entirely in favor of it, but I also don't have a problem letting the > community majority decide what to do. > > but I will insist on a test that exercises the feature and its fix, so we > have something to point to if someone ever complains :) > > --Geoff > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > -- B e s t S o l u t i o n . a t EDV Systemhaus GmbH ------------------------------------------------------------------------ tom schindl leiter softwareentwicklung/CSE mobile ++43 676 3232147 ------------------------------------------------------------------------ eduard-bodem-gasse 8/3 A-6020 innsbruck fax ++43 512 935833 http://www.bestsolution.at phone ++43 512 935834
Index: src/docs/2.0/api/Apache2/RequestUtil.pod
===================================================================
--- src/docs/2.0/api/Apache2/RequestUtil.pod (Revision 386081)
+++ src/docs/2.0/api/Apache2/RequestUtil.pod (Arbeitskopie)
@@ -781,18 +781,16 @@
$val = $r->pnotes($key);
$hash_ref = $r->pnotes();
-B<Note:> sharing variables really means it. The variable is not copied.
-Only its reference count is incremented. If it is changed after being
-put in pnotes that change also affects the stored value. The following
-example illustrates the effect:
+B<NOTE:> that the for consitency reasons the behaviour(not the API) of pnotes
+has changed between 2.0.2 and 2.0.3. This means that code like the
+following behaves different in 2.0.2 and 2.0.3
- my $v=1; my $v=1;
- $r->pnotes( 'v'=>$v ); $r->pnotes->{v}=$v;
- $v++; $v++;
- my $x=$r->pnotes('v'); my $x=$r->pnotes->{v};
+ my $foo = 123;
+ $r->pnotes('foo' => $foo);
+ $foo = 456;
+ $r->pnotes('foo') # <== now 456 (in 2.0.2)
+ $r->pnotes('foo') # <== left at 123 (in 2.0.3)
-In both cases C<$x> is C<2> not C<1>. See also C<Apache2::SafePnotes> on
-CPAN.
=over 4
signature.asc
Description: OpenPGP digital signature
