Torsten Foertsch wrote: > On Thursday 18 October 2007, Philippe M. Chiasson wrote: >> Any chance you can break the patch into multiple patches > > This one registers the cleanup phase with a subpool to ensure it is run > before > pnotes are destroyed. Subpools are destroyed first thing in > apr_pool_{clear,destroy}. Hence, a pool cleanup registered with a subpool is > always called before a cleanup registered with the main pool.
Nice and elegant, and removes a piece of annoying, special-case code. Applied to trunk/ as r588156. Little style nit (see http://perl.apache.org/docs/2.0/devel/core/coding_style.html for the whole details. We globally use 4 spece indents, _not_ the \t (tab) character. ------------------------------------------------------------------------ Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature