Torsten Foertsch wrote:
On Fri 22 Feb 2008, Philippe M. Chiasson wrote:- parms.path = path; + parms.path = apr_pstrdup(p, path);Yes, Philippe, you are right. In current modperl there are 3 ways to get to modperl_config_insert(): - $r->add_config via modperl_config_insert_request - $s->add_config via modperl_config_insert_server - $parms->add_config via modperl_config_insert_parmsSince $parms->path is read-only and modperl_config_insert_server passes a NULL as path there is only one way to have a custom path passed to modperl_config_insert, modperl_config_insert_request. So patching $r->add_config only would be sufficient, as well.
Good digging, and correct.
Nevertheless, fixing it in modperl_config_insert is probably the best way regarding future changes.
Yes, it's generally safer to fix it at the source of the problem, as opposed to hoping folks don't make the same mistake in yet unwritten code. Committed revision 630597. -- Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature
