Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/8#discussion_r16695860
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -461,6 +471,57 @@ public MutationState createTable(CreateTableStatement 
statement, byte[][] splits
             MutationPlan plan = 
compiler.compile(Collections.singletonList(tableRef), emptyCF, null, null, 
tableRef.getTimeStamp());
             return connection.getQueryServices().updateData(plan);
         }
    +    
    +    public MutationState updateStatistics(UpdateStatisticsStatement 
updateStatisticsStmt) throws SQLException {
    +        String tableName = 
updateStatisticsStmt.getTable().getName().getTableName();
    +        HTableInterface ht = null;
    +        byte[] tenIdBytes = QueryConstants.EMPTY_BYTE_ARRAY;
    +        if (connection.getTenantId() != null) {
    +            tenIdBytes = connection.getTenantId().getBytes();
    +        }
    +        byte[] schNameInBytes = QueryConstants.EMPTY_BYTE_ARRAY;
    +        if (connection.getSchema() != null) {
    +            schNameInBytes = Bytes.toBytes(connection.getSchema());
    +        }
    +        final byte[] tenantIdBytes = tenIdBytes;
    +        final byte[] schemaNameInBytes = schNameInBytes;
    +        try {
    +            ht = 
connection.getQueryServices().getTable(Bytes.toBytes(tableName));
    --- End diff --
    
    Create an ConnectionQueryServices.updateStats(String tenantId, String 
schemaName, String tableName) method and move this code to 
ConnectionQueryServicesImpl. The idea is that all HBase code is encapsulated in 
that class. You can make the one in ConnectionlessQueryServicesImpl be a noop. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to