Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/10#issuecomment-54418091
-> Test cases are not running and all the test cases are failing at the
deleteTable sequence.
Post a stack trace - not sure offhand why this would be.
-> The checking of the timestamp stored in the table and avoiding
concurrent update stats does not work. I am checking on it.
-> The clearing of the metadata cache should happen in a lock? If so then
we need to see every where (even while reading from the cache) we should
introduce a new lock.
We shouldn't need a new lock. What's wrong with the existing lock mechanism?
-> Estimated byte size() is yet to be added to Ptable
This should be easy to add - just have your PTableStats implement a
getEstimatedSize() method and estimate based on the size of the guidepost
array.
-> Multi CF is not yet tested.
No problem - you can do this after your initial perf testing.
But this would help in getting the review done on the latest changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
