Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/12#discussion_r17406574
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -462,6 +477,71 @@ public MutationState createTable(CreateTableStatement
statement, byte[][] splits
return connection.getQueryServices().updateData(plan);
}
+ public long updateStatistics(UpdateStatisticsStatement
updateStatisticsStmt) throws SQLException {
+ String tableName =
updateStatisticsStmt.getTable().getName().getTableName();
+ // Check before updating the stats if we have reached the
configured time to reupdate the stats once again
+ long minTimeForStatsUpdate =
connection.getQueryServices().getProps()
+ .getLong(StatisticsConstants.MIN_STATS_FREQ_UPDATION,
StatisticsConstants.DEFAULT_STATS_FREQ_UPDATION);
+ // TODO : Check if we need the table key type of table name here.
+ // May be we can avoid multiple calls from the
+ // same connection
+ byte[] tenantIdBytes = QueryConstants.EMPTY_BYTE_ARRAY;
+ // TODO : If tenantId is not null we may have to get the actual
table name (PTable.getPhysicalName)
--- End diff --
We'll need to do this TODO, as otherwise the HTable won't be found for
views/multi-tenant tables. For example:
PName tenantId = connection.getTenantId();
TableName tableNameNode = statement.getTable().getName();
String schemaName = tableNameNode.getSchemaName();
String tableName = tableNameNode.getTableName();
// This will refetch the table from the server if necessary,
including re-fetching the stats
ColumnResolver resolver = FromCompiler.getResolver(statement,
connection);
PTable table = resolver.getTables().get(0).getTable();
byte[] physicalName = table.getPhysicalName();
// Query here for last_stats_update_time
if (table.getStats().getLastUpdateTime()
return new MutationState(0,connection);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
