Github user jyates commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/15#discussion_r17636539
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java ---
@@ -257,6 +264,18 @@ public static Span child(Span s, String d) {
public static CallWrapper withTracing(PhoenixConnection conn, String
desc) {
return new TracingWrapper(conn, desc);
}
+
+ private static void addCustomAnnotationsToSpan(@Nullable Span span,
@NotNull PhoenixConnection conn) {
+ Preconditions.checkNotNull(conn);
+
+ if (span != null) {
--- End diff --
nit: flip the logic and save the indent for readabililty
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
