[ 
https://issues.apache.org/jira/browse/PHOENIX-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168225#comment-14168225
 ] 

James Taylor commented on PHOENIX-1313:
---------------------------------------

Thanks for the help, [~rajesh23]. The start/stop keys of the scan look correct 
to with my patch. Each scan prepends the region prefix and goes between 00 and 
01, since it's using the first local index (and that's the index ID that should 
be next in each index row). The changes I've made are an attempt to reduce the 
special cases for local indexing. You want the start/stop key to be set 
according to the range on the original scan (i.e. the one calculated by 
WhereOptimizer). Otherwise you're doing a full region scan when it's not 
necessary.

Do the scan start/stop look correct to you? We detect the first stale region 
and re-calculate the Scan for what were the old scan boundaries. Maybe this is 
uncovering a new issue?

> Investigate why LocalIndexIT.testLocalIndexScanAfterRegionSplit() is failing
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1313
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1313
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.2
>            Reporter: James Taylor
>            Assignee: rajeshbabu
>             Fix For: 5.0.0, 4.2
>
>         Attachments: PHOENIX-1313.patch, PHOENIX-1313_2.patch
>
>
> I checked in a fairly big change 
> (https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=d018cc1c6e01d9836de6e67af4f8b91de3269bfd)
>  to improve encapsulation and fix a bunch of stats issues, and the following 
> test started failing: LocalIndexIT.testLocalIndexScanAfterRegionSplit(). I 
> tried to diagnose it, but that test is complicated. Would you mind taking a 
> look [~rajesh23]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to