The backward compat issue sinks the RC. IMO, it doesn't matter that we didn't catch the issue in 4.2.0. PHOENIX-1434 has a workaround (set the guidepost depth to the region size). This will achieve the same behavior that existed since pre 4.0.
I agree, though, we should implement the new optimization for PHOENIX-1434. I don't think PHOENIX-1428 will make it for the patch release (unless someone else is working on this that I don't know about). On Tue, Nov 11, 2014 at 1:57 PM, Eli Levine <[email protected]> wrote: > Agree on the other issues. Just wanted to clarify that we are not sinking > this RC solely because of the compat issue. > > On Tue, Nov 11, 2014 at 1:54 PM, Mujtaba Chohan <[email protected]> wrote: > >> Eli - Drop table compatibility issue would be there in 4.2.0 however stats >> not getting updated correctly is important >> https://issues.apache.org/jira/browse/PHOENIX-1434 and also good if we get >> fix for PHOENIX-1428 and PHOENIX-1429. >> >> -mujtaba >> >> . >> >> On Tue, Nov 11, 2014 at 1:43 PM, Eli Levine <[email protected]> wrote: >> >> > Mujtaba, is this a new issue or is it there in 4.2.0? If it's in 4.2.0 >> not >> > sure it's enough to sink this RC, since it's not a regression. >> > >> > Thanks, >> > >> > Eli >> > >> > On Mon, Nov 10, 2014 at 12:11 PM, Mujtaba Chohan <[email protected]> >> > wrote: >> > >> > > -1. >> > > >> > > Drop table doesn't work with Phoenix 4.1 client with 4.2.1-RC0 on >> server >> > > side. >> > > Exception: com.google.protobuf.UninitializedMessageException: Message >> > > missing required fields: cascade >> > > >> > > On Sun, Nov 9, 2014 at 11:49 PM, Gabriel Reid <[email protected]> >> > > wrote: >> > > >> > > > +1 to release >> > > > >> > > > * Verified signatures and checksums >> > > > * Ran rat >> > > > * Verified contents of source distribution vs tag in git >> > > > * Successfully ran full integration test suite >> > > > >> > > > >> > > > On Fri, Nov 7, 2014 at 8:54 PM, James Taylor <[email protected] >> > >> > > > wrote: >> > > > > Hello everyone, >> > > > > >> > > > > This is a call for a vote on Apache Phoenix 4.2.1 RC0. This is a >> bug >> > > > > fix/patch release of Phoenix 4.2, compatible with the 0.98 branch >> of >> > > > > Apache HBase with feature parity against the Phoenix 3.2 release. >> The >> > > > > release includes both a source-only release and a convenience >> binary >> > > > > release. >> > > > > >> > > > > For a complete list of changes, see: >> > > > > https://raw.githubusercontent.com/apache/phoenix/4.2/CHANGES >> > > > > >> > > > > The source tarball, including signatures, digests, etc can be found >> > at: >> > > > > >> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.2.1-rc0/src/ >> > > > > >> > > > > The binary artifacts can be found at: >> > > > > >> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.2.1-rc0/bin/ >> > > > > >> > > > > Release artifacts are signed with the following key: >> > > > > https://people.apache.org/keys/committer/mujtaba.asc >> > > > > >> > > > > KEYS file available here: >> > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS >> > > > > >> > > > > The hash and tag to be voted upon: >> > > > > >> > > > >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=73738f4cd6fc2be7b07e660ba4915b1e850627c6 >> > > > > >> > > > >> > > >> > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/v4.2.1-rc0 >> > > > > >> > > > > Vote will be open for at least 72 hours. Please vote: >> > > > > >> > > > > [ ] +1 approve >> > > > > [ ] +0 no opinion >> > > > > [ ] -1 disapprove (and reason why) >> > > > > >> > > > > Thanks, >> > > > > The Apache Phoenix Team >> > > > >> > > >> > >>
