[ 
https://issues.apache.org/jira/browse/PHOENIX-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214875#comment-14214875
 ] 

Andrew Purtell commented on PHOENIX-1455:
-----------------------------------------

bq. At the time of impl, I have tested with lowering default value and manually 
testing.

Thanks Anoop. So I can commit this? 

Or is it waiting for a test? I could make two derived IT tests for 
DistinctCount and HashJoin that set DISTINCT_VALUE_COMPRESS_THRESHOLD_ATTRIB to 
1 (thanks for the info about that). But if you have already done that we could 
commit this change and tests for it separately. 

> Replace org.xerial.snappy with org.iq80.snappy pure Java snappy implementation
> ------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1455
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1455
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 5.0.0, 4.2, 3.2
>
>         Attachments: PHOENIX-1455.patch
>
>
> We can avoid Phoenix runtime dependencies on native snappy support by using 
> the all Java snappy compression implementation found at 
> https://github.com/dain/snappy. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to