[
https://issues.apache.org/jira/browse/PHOENIX-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224932#comment-14224932
]
Samarth Jain edited comment on PHOENIX-1467 at 11/25/14 6:17 PM:
-----------------------------------------------------------------
Thanks for committing the patch [~jamestaylor]. The changes in non-test files
were mostly fixes for warnings because of unused imports or resource leaks
(like a result set/statement wasn't closed). But if it's preferable, I will get
you the patches with test only changes for 4.0, 3.0 and master branches. We can
deal with the code janitorial work later.
was (Author: samarthjain):
Thanks for committing the patch [~jamestaylor]. The changes in non-test files
were mostly fixes for warnings because of unused imports. I will get you the
patches for all the three branches 4.0, 3.0 and master with test only changes
soon.
> Upgrade to 4.12 Junit and update tests by removing @Category annotation
> -----------------------------------------------------------------------
>
> Key: PHOENIX-1467
> URL: https://issues.apache.org/jira/browse/PHOENIX-1467
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-1467.patch
>
>
> The 4.12 Junit release makes the @Category annotation inheritable. This means
> we no longer need to annotate each our test classes with category annotations
> like @Category(NeedsOwnMiniClusterTest.class).
> Test classes that inherit from one of these base test classes -
> BaseOwnClusterIT, BaseClientManagedTimeIT and BaseHBaseManagedTimeIT will get
> automatically categorized into @Category(NeedsOwnMiniClusterTest.class),
> @Category(ClientManagedTimeTest.class) and
> @Category(HBaseManagedTimeTest.class) respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
