[ 
https://issues.apache.org/jira/browse/PHOENIX-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232768#comment-14232768
 ] 

James Taylor commented on PHOENIX-1485:
---------------------------------------

Yes, you're right, there's a problem with that code! How about this for 
simplicity?
{code}
            int requiredArgCount = 0;
            for (int i = 0; i < args.length; i++) {
                this.args[i] = new BuiltInFunctionArgInfo(d.args()[i]);
                if (this.args[i].getDefaultValue() == null) {
                    requiredArgCount = i+1;
                }
            }
{code}

One other thought I had - it'd be nice if there was a way of changing existing 
behavior of TO_DATE (while leaving it as-is by default). One way you could do 
this is to declare the default value in the annotation as "null", and then in 
the code in ToDateParseNode, use a new config property (or maybe using the 
phoenix.query.dateFormatTimeZone) to get the default timezone (defaulting to 
"GMT").

> Date columns should be displayed without timezone offset
> --------------------------------------------------------
>
>                 Key: PHOENIX-1485
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1485
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: noam bulvik
>         Attachments: PHOENIX-1485.1.patch, PHOENIX-1485.patch
>
>
> when date or timestamp  column queried the value is the date with timezone 
> offset. this is not how it is handled by other jdbc drivers like oracle and 
> impala. and it seems strange that when I have text file with specific date 
> and I use bulk loader to store it , when I will use select * .. I will get 
> different dates then the one in the file (because  of the time zone offset)
> by default the date should be displayed without any offset.
> it will be nice to have an option to add the timezone offset the option in 
> the driver 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to