[ https://issues.apache.org/jira/browse/PHOENIX-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237514#comment-14237514 ]
James Taylor commented on PHOENIX-1498: --------------------------------------- Good catch. I had assumed it'd have the default version of 3 based on the 0.94 default (before you reminded me that the default is now 1 for 0.98). It wouldn't make sense to have 1000 versions of stats, IMO. The SYSTEM.STATS rows will honor the CURRENT_SCN property (which is the important part IMO), so if VERSIONS is set to something other than 1, it should work correctly. But this is really an edge case, relying on versioning of stats. What do you think we should do? Maybe we can have a phoenix.stats.default.versions property for the default number of stats row versions? The change you're making for having the default value of KEEP_DELETED_CELLS set to false is more important. > Turn KEEP_DELETED_CELLS off by default > -------------------------------------- > > Key: PHOENIX-1498 > URL: https://issues.apache.org/jira/browse/PHOENIX-1498 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.0.0, 5.0.0 > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Attachments: PHOENIX-1498-v2.patch, PHOENIX-1498.patch > > > Phoenix table is created with "KEEP_DELETED_CELLS" enabled by default, this > is only used to allow for flashback queries to work correctly. While > flashback query isn't used often in field and we found that query performance > degraded with the option on. This is likely a hbase scan issue though(will > create a JIRA once having more info). > Anyway Keeping deleted cells will add performance penalty and it's not used > often. Therefore, I'm suggesting to set it off by default. > We have a test where a table is loaded with > 5m rows and then some are > deleted/reinserted. The count ( * ) performance became worse & worse: > {code} > +------------+ > | COUNT(1) | > +------------+ > | 5078242 | > +------------+ > 1 row selected (33.273 seconds) > +------------+ > | COUNT(1) | > +------------+ > | 5078242 | > +------------+ > 1 row selected (174.771 seconds) > +------------+ > | COUNT(1) | > +------------+ > | 5078242 | > +------------+ > 1 row selected (458.251 seconds) > {code} > I think we can provide a table property in CREATE TABLE & ALTER TABLE > statement for people to enable KEEP_DELETED_CELLS if there is a need but by > default it should be turned off. -- This message was sent by Atlassian JIRA (v6.3.4#6332)