[
https://issues.apache.org/jira/browse/PHOENIX-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238318#comment-14238318
]
Gabriel Reid commented on PHOENIX-1454:
---------------------------------------
Looks pretty good to me.
I tried applying the patch to master and there seemed to be an issue there, but
applying it to the 4.0 branch went fine.
A really minor nit that I noticed is some inconsistent exception handling in
PhoenixRecordWriter: the {{close()}} method will throw a RuntimeException if a
SQLException occurs in an underlying call, but the {{write()}} method throws a
RuntimeException. Looks like it would be better if they both did the same thing
(unless this is intentional for a reason).
One less minor thing that I think would be good to improve is having a simple
integration test that demonstrates the usage of a single MapReduce job, or
maybe one that reads and one that writes. I guess this is indirectly covered by
the pig integration tests (right?) but it seems like it would be good to have
something specifically testing this.
> Map Reduce over Phoenix tables
> ------------------------------
>
> Key: PHOENIX-1454
> URL: https://issues.apache.org/jira/browse/PHOENIX-1454
> Project: Phoenix
> Issue Type: New Feature
> Reporter: maghamravikiran
> Assignee: maghamravikiran
> Labels: mapreduce
> Attachments: 0001-PHOENIX-1454-Map-Reduce-over-Phoenix-Table.patch
>
>
> Provide API to enable MR jobs on Phoenix tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
