[ 
https://issues.apache.org/jira/browse/PHOENIX-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243420#comment-14243420
 ] 

Nick Dimiduk commented on PHOENIX-1517:
---------------------------------------

Am I understanding this method intention? The following test looks reasonable?

{noformat}
    // DECIMAL does not cast into CHAR
    assertFalse(PDataType.CHAR_ARRAY.isSizeCompatible(LARGE_DECIMAL_ENCODED, 
LARGE_DECIMAL,
        PDataType.CHAR_ARRAY, null, null, null, null));
{noformat}

> PArrayDataType#isSizeCompatible not invoked for all array types
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-1517
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1517
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>
> I noticed this while debugging failures in ArrayIT with my patch on 
> PHOENIX-1514. It looks like The intention is for all array types to defer 
> their implementation of isSizeCompatible to the implementation in 
> PArrayDataType. However, this is only done for VARCHAR_ARRAY, 
> VARBINARY_ARRAY, BINARY_ARRAY, CHAR_ARRAY, and DECIMAL_ARRAY. Everything 
> else, (basically, all the arrays of primitive types) are invoking the default 
> implementation in PDataType, which always returns true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to