[ 
https://issues.apache.org/jira/browse/PHOENIX-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253136#comment-14253136
 ] 

Gabriel Reid commented on PHOENIX-1543:
---------------------------------------

Related, and making it more of a backwards-compatibility issue, is the 
following statement from the javadoc of 
[Connection.commit|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#commit()]:
{quote}
throws SQLException ... if this Connection object is in auto-commit mode
{quote}

We don't currently do this, but making this change would mean that any code 
that currently opens a new connection and then calls commit (without disabling 
autoCommit) would (should) throw an SQLException.

> AutoCommit should be turned on by default on new connections
> ------------------------------------------------------------
>
>                 Key: PHOENIX-1543
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1543
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>
> According to the javadoc for 
> [Connection|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html],
>  and also for 
> [Connection.setAutoCommit|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#setAutoCommit(boolean)],
>  auto-commit should be turned on by default on new connections. Taken from 
> the javadoc:
> {quote}
> By default a Connection object is in auto-commit mode, which means that it 
> automatically commits changes after executing each statement.
> {quote}
> Phoenix currently sets auto-commit to false by default on new connections.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to