[
https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256207#comment-14256207
]
Alicia Ying Shu edited comment on PHOENIX-1409 at 12/22/14 9:47 PM:
--------------------------------------------------------------------
[~giacomotaylor] Thanks for reviewing my previous patch. I uploaded a new
version with some fixes:
* Fixed the issues you mentioned in your comments.
* The indentation you mentioned in your comments is an existing issue, it was
off before.
* Added some test cases to cover setting column family properties, setting
table properties, setting Phoenix table properties across single and multiple
column family scenarios.
* Fixed an issue with setting table properties.
The tests all passed locally in my local env.
was (Author: aliciashu):
[~giacomotaylor] Thanks for reviewing my previous patch. I uploaded a new
version with some fixes:
* Fixed the issues you mentioned in your comments.
* The indentation you mentioned in your comments is an existing issue, it was
off before.
* Added some test cases to cover setting column family properties, setting
table properties, setting Phoenix table properties across single and multiple
column family scenarios.
* Fixed an issue with setting table properties.
> Allow ALTER TABLE <table> SET command to update HTableDescriptor and
> HColumnDescriptor properties
> -------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1409
> URL: https://issues.apache.org/jira/browse/PHOENIX-1409
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.2
> Reporter: James Taylor
> Assignee: Alicia Ying Shu
> Attachments: Phoenix-1409-v1.patch, Phoenix-1409.patch, WIP.patch,
> phoenix-1409-v2.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and
> HColumnDescriptor properties through the ALTER TABLE <table> SET command.
> It'd just be a matter of passing these properties through the existing
> methods, as we support this for CREATE TABLE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
