[
https://issues.apache.org/jira/browse/PHOENIX-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1491:
----------------------------------
Summary: Do not pass through ParseNode arguments to compilation methods
(was: Do not require PhoenixConnection during compilation)
> Do not pass through ParseNode arguments to compilation methods
> --------------------------------------------------------------
>
> Key: PHOENIX-1491
> URL: https://issues.apache.org/jira/browse/PHOENIX-1491
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
>
> Instead of passing through ParseNode descendants (i.e. FilterableStatement,
> ParseNode tree for GROUP BY and ORDER BY), we should turn them into
> Expressions and work exclusively from those at compilation time.
> Examples include:
> - AggregatePlan and ScanPlan pass through FilterableStatement from which they
> get the hints and whether or not the query is distinct. We can instead pass
> these through as separate arguments.
> - OrderByCompiler, GroupByCompiler, and ProjectionCompiler all implement
> ParseNode visitors. Instead, we should drive these from Expression visitors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
