Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/34#discussion_r23669771
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -945,20 +960,40 @@ public MutationState createIndex(CreateIndexStatement
statement, byte[][] splits
PDataType dataType =
MetaDataUtil.getViewIndexIdDataType();
ColumnName colName =
ColumnName.caseSensitiveColumnName(MetaDataUtil.getViewIndexIdColumnName());
allPkColumns.add(new Pair<ColumnName,
SortOrder>(colName, SortOrder.getDefault()));
- columnDefs.add(FACTORY.columnDef(colName,
dataType.getSqlTypeName(), false, null, null, false, SortOrder.getDefault()));
+ columnDefs.add(FACTORY.columnDef(colName,
dataType.getSqlTypeName(), false, null, null, false, SortOrder.getDefault(),
null));
}
// First columns are the indexed ones
- for (Pair<ColumnName, SortOrder> pair : indexedPkColumns) {
- ColumnName colName = pair.getFirst();
- PColumn col = resolver.resolveColumn(null,
colName.getFamilyName(), colName.getColumnName()).getColumn();
- unusedPkColumns.remove(col);
- // Ignore view constants for updatable views as we
don't need these in the index
- if (col.getViewConstant() == null) {
- PDataType dataType =
IndexUtil.getIndexColumnDataType(col);
- colName =
ColumnName.caseSensitiveColumnName(IndexUtil.getIndexColumnName(col));
- allPkColumns.add(new Pair<ColumnName,
SortOrder>(colName, pair.getSecond()));
- columnDefs.add(FACTORY.columnDef(colName,
dataType.getSqlTypeName(), col.isNullable(), col.getMaxLength(),
col.getScale(), false, SortOrder.getDefault()));
- }
+ for (Pair<ParseNode, SortOrder> pair :
indexParseNodeAndSortOrderList) {
+ ParseNode parseNode = pair.getFirst();
+ ColumnName colName = null;
+ // if it is a column
+ if (parseNode instanceof ColumnParseNode) {
+ ColumnParseNode colParseNode =
(ColumnParseNode)parseNode;
+ PColumn col = resolver.resolveColumn(null,
colParseNode.getTableName(), colParseNode.getName()).getColumn();
+ unusedPkColumns.remove(col);
+ // Ignore view constants for updatable views as we
don't need these in the index
+ if (col.getViewConstant() != null)
+ continue;
+ colName =
ColumnName.caseSensitiveColumnName(IndexUtil.getIndexColumnName(col));
+ }
+ // compile the parseNode to get an expression
+ PhoenixStatement phoenixStatment = new
PhoenixStatement(connection);
+ final StatementContext context = new
StatementContext(phoenixStatment, resolver);
+ ExpressionCompiler expressionCompiler = new
ExpressionCompiler(context);
+ Expression expression =
parseNode.accept(expressionCompiler);
+ if (expressionCompiler.isAggregate()) {
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.AGGREGATE_EXPRESSION_NOT_ALLOWED_IN_INDEX).build().buildException();
+ }
+ if (expression.getDeterminism() != Determinism.ALWAYS)
{
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.NON_DETERMINISTIC_EXPRESSION_NOT_ALLOWED_IN_INDEX).build().buildException();
+ }
+
+ PDataType dataType =
IndexUtil.getIndexColumnDataType(expression.isNullable(),
expression.getDataType());
+ colName = colName != null ? colName :
+
ColumnName.caseSensitiveColumnName(IndexUtil.getIndexColumnName(null,
expression.toString().replaceAll("\"", "")));
--- End diff --
Why is the string replace necessary? Note that by going from parseNode ->
expression -> string, you'll have case sensitive column, table, and schema
references
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
