Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/34#discussion_r23720074
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/expression/Expression.java ---
    @@ -88,4 +88,9 @@
          * @return
          */
         boolean requiresFinalEvaluation();
    +    
    +    /**
    +     * @return the estimated size in bytes of the expression when 
serialized
    +     */
    +    int getEstimatedByteSize();
    --- End diff --
    
    The only place where this is used is in IndexMaintainer serialize, if we 
are moving to Protobufs then this change is not worth it, I will remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to