[ 
https://issues.apache.org/jira/browse/PHOENIX-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313450#comment-14313450
 ] 

Hudson commented on PHOENIX-1646:
---------------------------------

FAILURE: Integrated in Phoenix-master #585 (See 
[https://builds.apache.org/job/Phoenix-master/585/])
PHOENIX-1646 Views and functional index expressions may lose information when 
stringified (jtaylor: rev abeaa74ad35e145fcae40f239437e1b5964bcd72)
* phoenix-core/src/main/java/org/apache/phoenix/parse/NamedTableNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ModulusParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/OuterJoinParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/CompoundParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/BindParseNode.java
* 
phoenix-core/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ColumnDef.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/RowValueConstructorParseNode.java
* 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/AliasedNode.java
* phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/DistinctCountParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/AndParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/ArrayAllComparisonNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/StringConcatParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/DerivedTableNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/CaseParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/MultiplyParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/SelectStatement.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/JoinTableNode.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/FamilyWildcardParseNode.java
* 
phoenix-core/src/test/java/org/apache/phoenix/query/BaseConnectionlessQueryTest.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ArrayElemRefNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/AddParseNode.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ConcreteTableNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/IsNullParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ArrayConstructorNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/DivideParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/InListParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/WildcardParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/OrderByNode.java
* phoenix-core/src/main/java/org/apache/phoenix/util/StringUtil.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ColumnParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/BetweenParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/util/QueryUtil.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/LikeParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/LiteralParseNode.java
* phoenix-core/src/test/java/org/apache/phoenix/compile/WhereOptimizerTest.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ArithmeticParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/NotParseNode.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/AggregateFunctionWithinGroupParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/SubtractParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/NamedParseNode.java
* phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/ArrayAnyComparisonNode.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDate.java
* phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/LimitNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/NamedNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/SubqueryParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/TableNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/InParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/TableName.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/ArrayAllAnyComparisonNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/TableWildcardParseNode.java
* 
phoenix-core/src/main/java/org/apache/phoenix/parse/SequenceValueParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/FunctionParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/BindTableNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ExistsParseNode.java
* phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/types/PVarchar.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/HintNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/ComparisonParseNode.java
* phoenix-core/src/main/java/org/apache/phoenix/parse/OrParseNode.java


> Views and functional index expressions may lose information when stringified
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-1646
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1646
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-1646-wip.patch, PHOENIX-1646.patch, 
> PHOENIX-1646_v2.patch
>
>
> We currently produce a string from an Expression to store in the system 
> catalog for views and functional indexes. However there are a number of 
> constructs that won't roundtrip correctly, mainly due to the way expression 
> trees get collapsed during compilation. The easiest way to fix this is to go 
> from the ParseNode to a string instead and fully resolve column names in the 
> process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to